Skip to content

fix(ui): give the segment control a visible selected state - #61

Merged
Renekakpo merged 1 commit into
developfrom
fix/type-selector-legibility
Aug 12, 2026
Merged

fix(ui): give the segment control a visible selected state#61
Renekakpo merged 1 commit into
developfrom
fix/type-selector-legibility

Conversation

@Renekakpo

Copy link
Copy Markdown
Contributor

Why:

  • Selection was signalled by a soft shadow over two near-identical backgrounds: 1.06:1 contrast in the light theme, 1.27:1 in dark. There was effectively nothing to see, and nothing at all for a screen reader, since no accessibility helper in the codebase could emit accessibilityState.

What:

  • The selected segment now takes the accent fill the rest of the app already uses for selection, reaching 9.12:1 and 4.54:1. The sliding indicator is gone: it never rendered under test, so selected state had never been asserted anywhere. State now lives on each button, which makes it announceable and testable, and removed the only left-to-right assumptions in the control.

Why:
- Selection was signalled by a soft shadow over two near-identical backgrounds:
  1.06:1 contrast in the light theme, 1.27:1 in dark. There was effectively
  nothing to see, and nothing at all for a screen reader, since no accessibility
  helper in the codebase could emit accessibilityState.

What:
- The selected segment now takes the accent fill the rest of the app already
  uses for selection, reaching 9.12:1 and 4.54:1. The sliding indicator is gone:
  it never rendered under test, so selected state had never been asserted
  anywhere. State now lives on each button, which makes it announceable and
  testable, and removed the only left-to-right assumptions in the control.
@Renekakpo
Renekakpo merged commit 854a237 into develop Aug 12, 2026
1 check passed
@Renekakpo
Renekakpo deleted the fix/type-selector-legibility branch August 12, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant