fix(ui): align the transaction detail sheet with the app's sheet conv… - #58
Merged
Merged
Conversation
…entions Why: - The sheet was the only one with an icon at header right where every sibling puts text, and the only one whose hero glyph was a circle while the identical category glyph is a rounded square in the list rows. The delete control rendered as an empty Text to screen readers, naming the action for nobody, and the title was hardcoded English. What: - Delete reads as text using the existing common.delete label, the hero glyph takes the same radius as the list rows, both header controls carry a proper accessibility role, and the title is translated across the five complete locales. The list renderers are untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…entions
Why:
What: