Repository navigation
Narrow built-in/foreign function replacement coverage - #431
Merged
Merged
Conversation
batmendbar
marked this pull request as draft
October 26, 2026 10:32
Contributor
|
Overall success rate on test cases: 100.0% No test improvements or size changes detected. Comparison Base DetailsCompared against: Committed STATUS.md at |
Contributor
|
Overall success rate on test cases: 100.0% No test improvements or size changes detected. Comparison Base DetailsCompared against: STATUS.md artifact from |
Contributor
|
Overall success rate on test cases: 100.0% No test improvements or size changes detected. Comparison Base DetailsCompared against: STATUS.md artifact from |
iamrecursion
approved these changes
Oct 27, 2026
iamrecursion
left a comment
iamrecursion
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Nice small fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noir only allows built-in/foreign functions in stdlib. Our codebase currently applies replacements to all noir sources including user code. This PR narrows replacement coverage to only stdlib.