Repository navigation
app-core: keep the persist setting when an instance is removed - #2127
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
removeState rebuilt the instances state without the persisted flag, so removing an instance turned persist off. In the extension, turning persist off removes disconnected instances first, which cleared the flag before the toggle flipped it back on.
🦋 Changeset detectedLatest commit: 8225e3c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
removeStateinpackages/redux-devtools-app-core/src/reducers/instances.tsreturns a new instances state built from scratch, withoutpersisted. AnyREMOVE_INSTANCEtherefore resets the persist setting toundefined.Based on where
REMOVE_INSTANCEis dispatched, this has two effects:togglePersist()in the background removes disconnected instances before the toggle reaches the reducer. The removal clearspersisted, soTOGGLE_PERSISTflipsundefinedtotrueand the monitors receiveSET_PERSISTwithtrue.Changes
removeStatereturns, so fields it does not change are preserved.REMOVE_INSTANCEthat checkspersistedis kept.@redux-devtools/app-core.Testing
pnpm vitest --run --project app-core test/instances.spec.tsfails without the fix (expected undefined to be true) and passes with it.Fixes #2126