skills: drift audit (2026-09) - #61
Open
micheleRP wants to merge 1 commit into
Open
Conversation
…BYOC networks Monthly full re-verification against current stable sources. Nine corrections across five skills; no volatile detail added. rpk (-X reference): - Correct four wrong default values. The "Default" column had been populated from a test-example field rather than the real defaults: globals.command_timeout 30s -> 10s, globals.request_timeout_overhead 10s -> 5s, globals.retry_timeout 30s -> 11s, globals.prompt 'bg-red "%n"' -> unset. - Address defaults are 127.0.0.1:9092 / :9644 / :8081, not localhost:*. - An unset sasl.mechanism falls back to SCRAM-SHA-256 for the Kafka API too, not only for Admin API basic auth. - Describe `rpk -X list` as listing value formats, not defaults, and point at live introspection as authoritative over the static table. - Record in SOURCES.md that there is no -X defaults struct, and which source is authoritative for each key's default. rpk-security, streaming-admin-api: - superusers, enable_sasl and kafka_enable_authorization are cluster configuration properties, not node properties in redpanda.yaml, and none of them requires a broker restart. Replace the redpanda.yaml-plus-restart guidance with `rpk cluster config set`, and note .bootstrap.yaml for pre-boot seeding. - Reorder the SASL bootstrap flow to create the superuser before enabling authentication; the old order locked the operator out. - Note that kafka_enable_authorization is nullable and follows enable_sasl when unset. rpk-security, connect-debugging: - Fix two examples using non-existent `-X sasl.username` / `-X sasl.password` flags; the keys are `user` and `pass`. cloud-byoc: - Document the network PATCH endpoint and its update_mask form, with the PREVIEW caveat on both settable fields. - Add the PREVIEW public_subnets field to the AWS customer-managed-resources table (dual-listener clusters, write-once). - Document the cloud-provider-access prerequisites endpoint and lead the workflow with it, since the IAM role must already trust Redpanda before the access can be registered. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Monthly full re-verification of the source-grounded skills against current source, rather than against recent commits. Nine corrections across five skills. No volatile detail added — every fix replaces a stale or wrong stable fact.
Verified against Redpanda Core v26.2.2 (current stable) and Redpanda Connect v4.107.2 (current stable).
rpk—-Xreference (skills/rpk/references/x-flags-and-config.md)The "Default" column had been filled in from a test-example field in the rpk config source rather than from the real defaults. Four values were wrong:
-Xoptionglobals.command_timeout30s10sglobals.request_timeout_overhead10s5sglobals.retry_timeout30s11sglobals.promptbg-red "%n"Sources:
redpanda-data/redpandasrc/go/rpk/pkg/config/rpk_yaml.go(RpkGlobals.GetCommandTimeout()) andsrc/go/rpk/pkg/kafka/client_franz.go(thekgo.RequestTimeoutOverhead/kgo.RetryTimeoutoptions rpk applies over the franz-go defaults).globals.dial_timeout,globals.fetch_max_wait,globals.kafka_protocol_request_client_idandglobals.no_default_clusterwere checked and are correct.Also in the same file:
127.0.0.1:9092/127.0.0.1:9644/127.0.0.1:8081, notlocalhost-prefixed (src/go/rpk/pkg/config/params.go, which fills127.0.0.1plus the default port, and states the same inrpk -X help).sasl.mechanismfalls back toSCRAM-SHA-256for the Kafka API as well, not only for Admin API basic auth (src/go/rpk/pkg/kafka/client_franz.go).rpk -X listprints each key's accepted value format, not its default — the discovery section said "short list with defaults". Added a line making live introspection authoritative over the static table.references/SOURCES.mdnow records that rpk has no-Xdefaults struct, and names the authoritative source for each key's default, so this class of error does not recur.rpk-security+streaming-admin-api— superuser and SASL configurationsuperusers,enable_saslandkafka_enable_authorizationare cluster configuration properties, and all three carryneeds_restart: no. The skills described them as node properties inredpanda.yamlrequiring a broker restart, and told the reader they could not manage superusers with rpk at all.redpanda.yaml+ restart guidance withrpk cluster config set, noting that array-valued properties take a quoted list. Pre-boot seeding goes in the cluster bootstrap file, notredpanda.yaml.kafka_enable_authorizationis nullable and followsenable_saslwhen left unset.authenticatedin the docs is theuserenum member.Sources:
redpanda-data/redpandasrc/v/config/configuration.handconfiguration.cc(all three declared on the clusterconfigurationclass withneeds_restart::no), theconfig::shard_local_cfg().superusers()call sites insrc/v/security/authorizer.ccandsrc/v/kafka/server/connection_context.cc, andsrc/v/redpanda/admin/server.cc, which re-reads the value on a cluster-config update touchingsuperusers— direct evidence no restart is involved. Files touching these facts elsewhere (streaming-admin-api/references/cluster-config.md,rpk-cluster/references/config.md) already had it right; the repo was internally inconsistent.rpk-security+connect-debugging— broken-XexamplesTwo examples used
-X sasl.username=/-X sasl.password=, which are not rpk-Xkeys and would be rejected. The keys areuserandpass(src/go/rpk/pkg/config/params.go). Fixed inrpk-security/references/users.mdandconnect-debugging/references/failure-modes.md.Swept mechanically as a cross-check: every
-Xkey occurrence in every skill was extracted and diffed against the authoritative key list. These two were the only invalid ones. The-X sasl.username=lines incloud-dedicated/references/data-plane.mdarekcatinvocations, where that spelling is correct librdkafka syntax, and were left alone.cloud-byoc— networks and cloud provider accessThree surfaces existed in the API but were absent from the skill:
PATCH /v1/networks/{network.id}was undocumented; the reference had only create, get/list and delete. Added an "Updating a Network" section covering the body/update_maskshape and the operation it returns, with the caveat that both settable fields are PREVIEW. (The skill already cited this operation's type value in the Dedicated reference, so the enum was known but the endpoint was not.)public_subnetson the AWS customer-managed-resources table — PREVIEW, optional, needed only for a dual-listener cluster, and write-once.Full provenance, including the sources for the private-source fixes and the items left as TODOs for human review, is in the routine's private report. That report also records this pass's coverage explicitly: the SQL skills and most of the Connect and Core command skills were not re-verified this month and carry over.
🤖 Generated with Claude Code