gotohelm: align values loading with helm - #1804
Open
chrisseto wants to merge 1 commit into
Open
Conversation
chrisseto
requested review from
RafalKorepta,
andrewstucki,
gene-redpanda and
hidalgopl
as code owners
September 2, 2026 18:33
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Prior to this change a subtle divergence existed between gotohelm's and
helm's values loading.
Helm has a "coalescing" process for merging user values that's more
involved than a simple recursive merge. It walks the chart's default
values and prunes any user provided `null`s.
chart defaults:
```yaml
nested:
a: "hello"
name: "world"
forDocs: null
```
user values:
```yaml
name: null
nested:
a: null
```
Coalesced result:
```
nested: {}
forDocs: null
```
This commit utilizes helm's internal helpers to better match its
behavior and add regression tests.
As a side effect, the output of LoadValues should no longer be passed to
Dot. The few such call sites have been corrected.
chrisseto
force-pushed
the
chris/gotohelm-values
branch
from
September 2, 2026 21:35
04c3ba1 to
bf7a2cc
Compare
RafalKorepta
approved these changes
Sep 3, 2026
Comment on lines
+284
to
+287
| metadata.Dependencies = slices.Clone(c.metadata.Dependencies) | ||
| for i, dep := range metadata.Dependencies { | ||
| cloned := *dep | ||
| metadata.Dependencies[i] = &cloned |
Contributor
There was a problem hiding this comment.
I don't fully understand why after cloning the slice range over and temporar variable created. Maybe I'm missing something
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change a subtle divergence existed between gotohelm's and
helm's values loading.
Helm has a "coalescing" process for merging user values that's more
involved than a simple recursive merge. It walks the chart's default
values and prunes any user provided
nulls.chart defaults:
user values:
Coalesced result:
This commit utilizes helm's internal helpers to better match its
behavior and add regression tests.
As a side effect, the output of LoadValues should no longer be passed to
Dot. The few such call sites have been corrected.
Stack created with GitHub Stacks CLI • Give Feedback 💬