Deprecate remaining Server, Cluster, Client, and Connection Commands - #3847
Open
juntae6942 wants to merge 6 commits into
Open
Deprecate remaining Server, Cluster, Client, and Connection Commands#3847juntae6942 wants to merge 6 commits into
juntae6942 wants to merge 6 commits into
Conversation
a-TODO-rov
requested changes
Jul 16, 2026
a-TODO-rov
left a comment
Collaborator
There was a problem hiding this comment.
General approach we use is:
- Edit templates
- Run generators (pay attention to Constants class, generators are not idempotent ...)
- Check created changes and fix manually if needed, so only the relevant ones remain.
Collaborator
There was a problem hiding this comment.
Generally, no need to deprecate those.
| * @deprecated since 7.7, use {@link #SHARDS} instead. | ||
| */ | ||
| @Deprecated | ||
| SLOTS, |
Collaborator
There was a problem hiding this comment.
This is honestly wrong. Multiple usages.
Collaborator
There was a problem hiding this comment.
We generally dont depraecate those.
Author
|
Hi @a-TODO-rov, thanks for the detailed guidance! I've updated the PR based on your feedback:
Could you please take another look? Let me know if there's anything else I need to fix! |
juntae6942
force-pushed
the
feature/3796-deprecate-remaining-commands
branch
from
August 9, 2026 23:56
0c1704c to
f0d3dd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3796
This PR addresses the remaining deprecations for Server, Cluster, Client, and Connection commands as outlined in #3796.
Changes included:
@Deprecatedannotations and@deprecatedJavadoc tags (pointing to their respective replacements since 7.7) for the following commands:QUIT(UseStatefulConnection.close()instead)SLAVEOF(UseREPLICAOFinstead)CLUSTER SLAVES(UseCLUSTER REPLICASinstead)CLUSTER SLOTS(UseCLUSTER SHARDSinstead)CLIENT KILL <addr>(UseclientKill(KillArgs)instead)CommandTypeandCommandKeywordto reflect the deprecations.Note
Low Risk
Documentation-only API deprecations; existing call sites keep working until removal in a future release.
Overview
Marks several legacy Lettuce APIs as deprecated since 7.7 across sync, async, reactive, Kotlin coroutines, cluster node-selection, and Sentinel command interfaces—no runtime or wire-protocol behavior changes.
Connection:
quit()is deprecated in favor ofStatefulConnection.close()(including clusterBaseNodeSelectionCommands).Client:
clientKill(String addr)is deprecated in favor ofclientKill(KillArgs)on server and Sentinel APIs.Cluster:
clusterSlots()is deprecated in favor ofclusterShards()on cluster sync/async/reactive interfaces.Kotlin
quit()uses@Deprecated("Use StatefulConnection.close() instead.").CommandKeywordenum constants are regrouped on two lines (formatting only).BaseRedisCommandsgains an@authorline.Reviewed by Cursor Bugbot for commit f0d3dd1. Bugbot is set up for automated code reviews on this repo. Configure here.