Add stable API guards to text and textinput components (#57363) - #57363
Closed
coado wants to merge 2 commits into
Closed
Add stable API guards to text and textinput components (#57363)#57363coado wants to merge 2 commits into
coado wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109849283. |
coado
force-pushed
the
export-D109849283
branch
from
August 13, 2026 11:39
04eec03 to
a4692c6
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Aug 13, 2026
Summary: Pull Request resolved: react#57363 This diff rolls umbrella guards for `react/renderer/components/text` and `react/renderer/components/textinput`. Initially, we consider `text` component target as `public` and `textinput` as `for frameworks`, so the umbrella is added only to the `text` target. Changelog: [Internal] Differential Revision: D109849283
meta-codesync
Bot
changed the title
coado
force-pushed
the
export-D109849283
branch
from
August 13, 2026 12:52
a4692c6 to
e8152d4
Compare
Differential Revision: D109847184
coado
added a commit
to coado/react-native
that referenced
this pull request
Aug 17, 2026
Summary: Pull Request resolved: react#57363 This diff rolls umbrella guards for `react/renderer/components/text` and `react/renderer/components/textinput`. Initially, we consider `text` component target as `public` and `textinput` as `for frameworks`, so the umbrella is added only to the `text` target. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D109849283
coado
force-pushed
the
export-D109849283
branch
from
August 17, 2026 10:14
e8152d4 to
c9a3dfb
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Aug 17, 2026
Summary: Pull Request resolved: react#57363 This diff rolls umbrella guards for `react/renderer/components/text` and `react/renderer/components/textinput`. Initially, we consider `text` component target as `public` and `textinput` as `for frameworks`, so the umbrella is added only to the `text` target. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D109849283
coado
force-pushed
the
export-D109849283
branch
from
August 17, 2026 11:07
c9a3dfb to
ff728cf
Compare
Summary: Pull Request resolved: react#57363 This diff rolls umbrella guards for `react/renderer/components/text` and `react/renderer/components/textinput`. Initially, we consider `text` component target as `public` and `textinput` as `for frameworks`, so the umbrella is added only to the `text` target. This diff also adds missing `components/text/platform/android/` to the prefab as otherwise the Text umbrella cannot be properly resolved on Android. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D109849283
coado
force-pushed
the
export-D109849283
branch
from
August 17, 2026 11:12
ff728cf to
7cca432
Compare
|
This pull request has been merged in 385fa84. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff rolls umbrella guards for
react/renderer/components/textandreact/renderer/components/textinput.Initially, we consider
textcomponent target aspublicandtextinputasfor frameworks, so the umbrella is added only to thetexttarget.This diff also adds missing
components/text/platform/android/to the prefab as otherwise the Text umbrella cannot be properly resolved on Android.Changelog:
[Internal]
Reviewed By: cipolleschi
Differential Revision: D109849283