chore(release): v1.0.4, and test that every stated version agrees - #100
Merged
Merged
Conversation
Ships the near-unique cardinality fix from #97. The 1.0.3 release left the dbt install snippet in README.md and website/dbt-package.md at revision v1.0.2, so dbt users were told to install a stale tag. It is the second partial bump after v1.0.0 never reaching PyPI, and in both cases the checklist in CONTRIBUTING was the only guard. tests/test_release_versions.py now fails if pyproject, dbt_project.yml, both server.json fields or the dbt install snippets disagree with __version__; the bundle keeps its own guards in tests/test_mcpb.py. Against main it fails on exactly those two pins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ships the near-unique cardinality fix from #97 (thanks @bferanmi806-sketch).
Also fixes a drift I introduced
The 1.0.3 release left the dbt
git:install snippet inREADME.mdandwebsite/dbt-package.mdatrevision: v1.0.2, so dbt users were told to install a stale tag. That is the second partial version bump — v1.0.0 never reaching PyPI was the first — and both times the CONTRIBUTING checklist was the only guard.tests/test_release_versions.pynow fails ifpyproject.toml,dbt_project.yml, bothserver.jsonfields or the dbt install snippets disagree with__version__. Run againstmainit fails on exactly those two stale pins. The desktop bundle keeps its own guards intests/test_mcpb.py.Release
All locations bumped to 1.0.4, CHANGELOG section cut, CONTRIBUTING step 1 now lists every location and points at the test.