[LLM][3/N] Update Ray LLM to consume TPUAcceleratorConfig from Serve - #63216
Closed
ryanaoleary wants to merge 21 commits into
Closed
[LLM][3/N] Update Ray LLM to consume TPUAcceleratorConfig from Serve#63216ryanaoleary wants to merge 21 commits into
TPUAcceleratorConfig from Serve#63216ryanaoleary wants to merge 21 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables Ray LLM to use the new
TPUAcceleratorConfigfrom Serve implemented in #63179, replacing the deferred PG logic for scheduling workers. This resolves a critical bug where deferred placement groups left LLMServer replicas scheduled without accelerator constraints.Instead of deferring PG creation, we now pass the hardware topology directly to Serve. This ensures replicas are correctly constrained, allowing Serve to take ownership of the placement group lifecycle and successfully clean up temporary head placement groups upon readiness.
Key Changes:
LLMServer.get_deployment_optionsto translateTPUConfig into ServeTPUAcceleratorConfig` and inject it into the Serve decorator options.This PR includes the changes from #63177 and #63179 so that the integration tests work. This PR only modifies the following files, the rest are from the PR this is rebased on:
Related issues
#57137
Additional information