Skip to content

[History Server] Fix cold-load CPU starvation and per-event logging #5095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Future-Outlier wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −2
Open

[History Server] Fix cold-load CPU starvation and per-event logging #5095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
281ba9a
[History Server] Fix cold-load CPU starvation and per-event logging
Future-Outlier Aug 6, 2026
b3b2064
Merge remote-tracking branch 'origin/master' into historyserver-cold-…
Future-Outlier Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion historyserver/config/historyserver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,10 @@ spec:
ports:
- containerPort: 8080
resources:
limits:
requests:
cpu: "500m"
limits:
# Loading a dead session is CPU-bound: it uses ~1.2 cores with bursts
# to ~2.2. A 500m cap is saturated for the whole load, which made a
# 100k-task session take 907s instead of 63s.
cpu: "4"
Comment on lines +67 to +73

@win5923 win5923 Aug 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
requests:
cpu: "500m"
limits:
# Loading a dead session is CPU-bound: it uses ~1.2 cores with bursts
# to ~2.2. A 500m cap is saturated for the whole load, which made a
# 100k-task session take 907s instead of 63s.
cpu: "4"
requests:
cpu: "500m"

Just wondering if we should only set the CPU requests by default to disable CFS quota, and let users configure CPU limits themselves if they want them.

https://x.com/thockin/status/1134193838841401345

2 changes: 1 addition & 1 deletion historyserver/pkg/eventserver/eventserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ func (h *EventHandler) storeEvent(clusterSessionKey string, eventMap map[string]
}
eventType := types.EventType(eventTypeStr)

logrus.Infof("current eventType: %v", eventType)
logrus.Debugf("current eventType: %v", eventType)
switch eventType {
case types.TASK_DEFINITION_EVENT:
return h.handleTaskDefinitionEvent(eventMap, clusterSessionKey, false)
Expand Down
Loading