Skip to content

[Docs] Remove outdated postStart hook section from set_up_collector.md - #5083

Open
Future-Outlier wants to merge 2 commits into
ray-project:masterfrom
Future-Outlier:remove-outdated-poststart-doc
Open

[Docs] Remove outdated postStart hook section from set_up_collector.md#5083
Future-Outlier wants to merge 2 commits into
ray-project:masterfrom
Future-Outlier:remove-outdated-poststart-doc

Conversation

@Future-Outlier

Copy link
Copy Markdown
Member

Obsolete since #4983: the collector retrieves the node ID programmatically, so the postStart hook and the grep -oP note are no longer needed.

@Future-Outlier

Copy link
Copy Markdown
Member Author

The CI error is fixed here #5084

@machichima machichima left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@machichima

Copy link
Copy Markdown
Collaborator

cc @rueian and @andrewsykim for merging

@chiayi chiayi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants