Tolerances New PR - #161
Open
Sondar74 wants to merge 15 commits into
Open
Conversation
ranocha
requested changes
Sep 6, 2023
ranocha
left a comment
ranocha
left a comment
Owner
There was a problem hiding this comment.
Thanks for your work!
Also, the non-broken tests for the AVF method passed.
Do you mean that a previously broken test passes now? This is great! Could you please adapt the test accordingly?
ranocha
reviewed
Sep 7, 2023
ranocha
reviewed
Sep 7, 2023
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
ranocha
requested changes
Sep 11, 2023
ranocha
left a comment
ranocha
left a comment
Owner
There was a problem hiding this comment.
Thanks a lot for your patience. We're almost there
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New PR with tolerances.
Added absolute tolerance for
isapprox()and exact comparison forRationalinputs.New PR with one test for a RK method with Floating Inputs obtained from MatLab. Also, the non-broken tests for the AVF method passed.