Skip to content

Move rmarkdown from Imports to Suggests #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpsievert merged 4 commits into from
Apr 22, 2026
Merged

Move rmarkdown from Imports to Suggests #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2275b83
Move rmarkdown from Imports to Suggests
cpsievert Apr 21, 2026
abc18bc
Add NEWS entry for rmarkdown move to Suggests
cpsievert Apr 21, 2026
31fa821
Remove savewidget tests that only tested mock behavior
cpsievert Apr 21, 2026
cc8d25d
Address PR feedback: add rlang minimum version and guard test
cpsievert Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,10 @@ Imports:
htmltools (>= 0.5.7),
jsonlite (>= 0.9.16),
knitr (>= 1.8),
rmarkdown,
rlang (>= 1.0.0),
yaml
Suggests:
rmarkdown,
testthat
Comment thread
cpsievert marked this conversation as resolved.
Enhances:
shiny (>= 1.1)
Expand Down
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# htmlwidgets (development version)

* Moved `{rmarkdown}` from `Imports` to `Suggests`. It's now only required when calling `saveWidget(selfcontained = TRUE)`. (#455)

* htmlwidgets hex sticker added

* Static widget resize detection now uses `ResizeObserver` instead of `window.resize`, Bootstrap tab/collapse, and ioslides event listeners. This enables widgets to detect container-level size changes (e.g., CSS-driven resizing, sidebar toggles, flexbox/grid layout changes) that were previously missed. (#496)
Expand Down
7 changes: 6 additions & 1 deletion R/pandoc.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
write_md_for_pandoc <- function(html, file, background = "white", title, libdir = "lib", use_raw_attr = rmarkdown::pandoc_available("2.0")) {
write_md_for_pandoc <- function(html, file, background = "white", title, libdir = "lib", use_raw_attr = NULL) {
rlang::check_installed("rmarkdown")
if (is.null(use_raw_attr)) {
use_raw_attr <- rmarkdown::pandoc_available("2.0")
}
# Forked from htmltools::save_html to work better with pandoc_self_contained_html

# ensure that the paths to dependencies are relative to the base
Expand Down Expand Up @@ -60,6 +64,7 @@ write_md_for_pandoc <- function(html, file, background = "white", title, libdir
# The input should be the path to a file that was created using pandoc_save_markdown
pandoc_self_contained_html <- function(input, output) {

rlang::check_installed("rmarkdown")
if (!rmarkdown::pandoc_available()) {
stop(
"Saving a widget with selfcontained = TRUE requires pandoc. ",
Expand Down
1 change: 1 addition & 0 deletions tests/testthat/test-pandoc.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
test_that("Fix for issue #358 works", {
skip_if_not_installed("rmarkdown")
skip_if_not(
rmarkdown::pandoc_available(),
"Test requires pandoc to be installed"
Expand Down
Loading