Support NumPy 2.x 64bit integers on Windows - #551
Open
jfowkes wants to merge 1 commit into
Open
Conversation
jfowkes
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #551 +/- ##
=======================================
Coverage 27.44% 27.44%
=======================================
Files 152 152
Lines 28151 28151
Branches 8419 8419
=======================================
Hits 7725 7725
Misses 17958 17958
Partials 2468 2468 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
amontoison
approved these changes
Sep 11, 2026
Collaborator
Author
|
@amontoison should we be worried about the failing Poison tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumPy 2.x has changed the default integer type on Windows from 32bit (NPY_LONG) to 64bit (NPY_INTP):
https://numpy.org/devdocs/numpy_2_0_migration_guide.html#windows-default-integer
This PR fixes our Python interfaces to support both the old NumPy 1.x 32bit integer and the new Numpy 2.x 64bit integer.
I also suggest we do a new bugfix release of GALAHAD v5.5.2 after merging this PR so that we can update PyPI with Python 3.14 wheels (precompiled binaries) since 3.14 is the current stable release of Python and we should really be supporting it:
https://devguide.python.org/versions/