peek reports last used action - #964
Open
Macabe222 wants to merge 7 commits into
Open
Conversation
Oddant1
self-requested a review
August 18, 2026 19:09
Oddant1
removed their request for review
August 18, 2026 21:54
Contributor
|
@Macabe222, so the fundamental issue here is that before my commits, which were messing around with refactoring, the "load_action_yaml" methods existed in two places. One place was the _Archive classes, _ZipArchive and _NoOpArchive, but also one in core.util. I don't like it being in both places like this. @colinvwood and I talked about this, and the preferred place is the _Archive classes, but (and I think you saw this before) the util function is called in a few places in q2cli. Either we can keep all versions of load_action_yaml in util as I have them now, or you can put them back on _Archive and edit q2cli to use those methods. |
Oddant1
reviewed
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #423
Linked to rachis-org/rachis-cli#408
AI Disclosure