Skip to content

Transitive transformers - #959

Open
Macabe222 wants to merge 11 commits into
rachis-org:devfrom
Macabe222:transitiveformer
Open

Transitive transformers#959
Macabe222 wants to merge 11 commits into
rachis-org:devfrom
Macabe222:transitiveformer

Conversation

@Macabe222

@Macabe222 Macabe222 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Description

Makes transformers transitive.
For context read discussion in #933.

AI Disclosure

  • NO AI USED.
  • AI USED.

@Macabe222
Macabe222 marked this pull request as ready for review July 28, 2026 20:57
@Macabe222

Copy link
Copy Markdown
Contributor Author

@ebolyen What are your thoughts on capturing the transformers in provenance? Currently it only lists the first and last transformer used. @colinvwood's thoughts are to list each step and the plugin from which that transformer came from.

@ebolyen

ebolyen commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Yep! I think it should already be a yaml list in the action.yml to support this. So we just generate the path used, and in many cases it's just a single hop [start, end]. We can change the provenance transform recorder as needed, because that's an internal API.

@colinvwood

Copy link
Copy Markdown
Collaborator

It looks like we use the plugin key to refer to the plugin in which the transformed-to type is registered. However sometimes we will make hops across types that are not registered (because they are not directory formats). Should we in such cases report the plugin the transformer is registered in instead?

Comment thread src/rachis/core/transform.py Outdated
Comment thread src/rachis/core/archive/tests/test_citations.py Outdated
@ebolyen

ebolyen commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Yes, I think it should usually be the plugin that the transformer is registered to.

Comment thread src/rachis/sdk/result.py
return self._view(view_type)

def _view(self, view_type, recorder=None):
if view_type is rachis.Metadata and not self.has_metadata():

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants