Add support for transforming from unions - #934
Closed
colinvwood wants to merge 4 commits into
Closed
Conversation
Contributor
|
Could we perhaps move this into the transform module (both sides of the equation here)? I feel like I should be able to use That would also make it easier to test (I think). |
2 tasks
Collaborator
Author
|
replaced by #961 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for transforming from unions. Useful when a
TypeMatchrequires an action to return one of distinct view types.This mirrors what Michal added a few years ago to support transforming into a member of union, and factors the logic for both into a class method.
Would be helpful for an addition @miiixi1in is making to
q2_feature_table.rename_idsto allow us to rename feature IDs in any ofFeatureTable[*],FeatureData[Taxonomy],FeatureData[Sequence].