Skip to content

api(#1320): Add ComponentCache to ComponentSupportsConfigWhenManaged (#1320) #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fullsend-ai-coder wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

api(#1320): Add ComponentCache to ComponentSupportsConfigWhenManaged (#1320) #1321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apis/quay/v1/quayregistry_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ func NeedsBundleSecret(quay *QuayRegistry) bool {
// being Managed AND containing a custom user config provided through the config bundle
// secret.
func ComponentSupportsConfigWhenManaged(cmp Component) bool {
return cmp.Kind == ComponentRoute || cmp.Kind == ComponentMirror || cmp.Kind == ComponentRedis
return cmp.Kind == ComponentRoute || cmp.Kind == ComponentMirror || cmp.Kind == ComponentRedis || cmp.Kind == ComponentCache
}

func EnsureComponents(components []Component) []Component {
Expand Down
3 changes: 2 additions & 1 deletion controllers/quay/quayregistry_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1067,8 +1067,9 @@ func Test_hasNecessaryConfig(t *testing.T) {
quay: quayWithUnmanagedComponents(v1.ComponentCache),
},
{
// managed cache supports user config: operator overwrites infra fields anyway
name: "managed cache and redis but with provided config",
experr: true,
experr: false,
cfg: map[string][]byte{
"config.yaml": []byte("DATA_MODEL_CACHE_CONFIG:\n engine: redis\n redis_config:\n host: somehost\n port: 12345\n repository_blob_cache_ttl: 120s\n catalog_page_cache_ttl: 120s\n active_repo_tags_cache_ttl: 120s\n value_size_limit: 5MiB\n")},
quay: quayWithUnmanagedComponents(),
Expand Down
Loading