controllers(#1297): add missing TLS cipher assertions (#1297)

[fullsend-ai-coder]

The Old profile and nil-Custom profile test cases in TestTranslateTLSProfile had incomplete assertions. The Old profile was missing expectedCiphers for its 26 TLS 1.2 ciphers. The nil-Custom profile was missing both expectedCiphers and expectedCiphersuites (it defaults to Intermediate).

Add the missing assertions so breaking splitCiphers or translateTLSProfile causes test failures for these cases.

---

Closes #1297

Post-script verification

• Branch is not main/master (agent/1297-tls-test-assertions)
• Secret scan passed (gitleaks — 855b10b63223c6121c1c368678499f822bbf0446..HEAD)
• Pre-commit hooks passed (authoritative run on runner)
• Tests ran inside sandbox

[openshift-ci]

Hi @fullsend-ai-coder[bot]. Thanks for your PR.

I'm waiting for a quay member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.76%. Comparing base (855b10b) to head (496119e).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1301   +/-   ##
=======================================
  Coverage   66.76%   66.76%           
=======================================
  Files          26       26           
  Lines        4471     4471           
=======================================
  Hits         2985     2985           
  Misses       1486     1486           

Flag	Coverage Δ
unit-tests	66.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.