fix #1349, JobInterruptMonitorPlugin memory leak and concurrency issues - #1470
Open
e210 wants to merge 1 commit into
Open
fix #1349, JobInterruptMonitorPlugin memory leak and concurrency issues#1470e210 wants to merge 1 commit into
e210 wants to merge 1 commit into
Conversation
…concurrency issues Signed-off-by: Ezio Caffi <ezio.caffi@gmail.com>
e210
force-pushed
the
fix/1349-job-interrupt-monitor-memory-leak
branch
from
August 3, 2026 07:16
10f3b1d to
ba74cdd
Compare
Contributor
Author
|
Rebased onto latest The earlier red build wasn't caused by this PR: every build in that window failed (#1455, #1466–#1469 as well) and the pipeline recovered on its own by Feb 23. All checks are green now. @melloware this one has been sitting since February — anything else needed from my side? |
Contributor
|
No it looks good. I don't have commit permissions only review and tagging permissions. Only @jhouserizer can merge PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes three bugs in
JobInterruptMonitorPluginas reported in #1349.Fixes issue #1349
Changes
setRemoveOnCancelPolicy(true)onScheduledThreadPoolExecutorso cancelled tasks are immediately removed from the work queue, preventing memory leaksScheduledFuturefield with aConcurrentHashMap<String, ScheduledFuture>keyed byfireInstanceId, so concurrent jobs no longer overwrite eachother's monitor
getJobDetail().getJobDataMap()togetMergedJobDataMap()so thatAutoInterruptableandMaxRunTimecan be configured on the trigger as well as the jobChecklist
git commit -son my commits, and submit this code under terms of the Apache 2.0 license andassign copyright to the Quartz project owners
In submitting this contribution, I agree to the terms of contributing as referred to here:
https://github.com/quartz-scheduler/contributing/blob/main/CONTRIBUTING.md