Fixing calculation of getFireTimeAfter in CalendarIntervalTriggerImpl - #1438
Open
okokhanyy wants to merge 8 commits into
Open
Fixing calculation of getFireTimeAfter in CalendarIntervalTriggerImpl#1438okokhanyy wants to merge 8 commits into
okokhanyy wants to merge 8 commits into
Conversation
okokhanyy
marked this pull request as draft
December 13, 2025 04:39
okokhanyy
force-pushed
the
calendar_interval_trigger_fixes
branch
from
December 13, 2025 05:59
35fd691 to
bf17079
Compare
okokhanyy
marked this pull request as ready for review
December 13, 2025 06:18
okokhanyy
marked this pull request as draft
December 13, 2025 06:19
okokhanyy
force-pushed
the
calendar_interval_trigger_fixes
branch
from
December 15, 2025 22:00
32431b5 to
89c716d
Compare
okokhanyy
marked this pull request as ready for review
December 15, 2025 22:08
okokhanyy
marked this pull request as draft
December 16, 2025 19:18
okokhanyy
marked this pull request as draft
December 16, 2025 19:18
Signed-off-by: Oleksiy Kokhanyy <oleksiy.kokhanyy@socotra.com>
Signed-off-by: Oleksiy Kokhanyy <oleksiy.kokhanyy@socotra.com>
Signed-off-by: Oleksiy Kokhanyy <oleksiy.kokhanyy@socotra.com>
Signed-off-by: Oleksiy Kokhanyy <oleksiy.kokhanyy@socotra.com>
Signed-off-by: Oleksiy Kokhanyy <oleksiy.kokhanyy@socotra.com>
…ateTime arithmetic Signed-off-by: Oleksiy Kokhanyy <oleksiy.kokhanyy@socotra.com>
okokhanyy
force-pushed
the
calendar_interval_trigger_fixes
branch
from
January 15, 2026 06:07
bd5cfd5 to
b4b53e3
Compare
Signed-off-by: Oleksiy Kokhanyy <oleksiy.kokhanyy@socotra.com>
okokhanyy
marked this pull request as ready for review
January 20, 2026 18:29
melloware
approved these changes
Feb 14, 2026
Signed-off-by: Oleksiy Kokhanyy <oleksiy.kokhanyy@socotra.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following shortcomings with CalendarIntervalTriggerImpl.getFireTimeAfter(...):
Fix #1352
Fix #1444
Changes
Checklist
git commit -son my commits, and submit this code under terms of the Apache 2.0 license and assign copyright to the Quartz project owners(If you're not using command-line, you can use a browser extension )
In submitting this contribution, I agree to the terms of contributing as referred to here:
https://github.com/quartz-scheduler/contributing/blob/main/CONTRIBUTING.md