Skip to content

fix(prettier): honor .prettierignore during checks - #2751

Open
davehenton wants to merge 3 commits into
mainfrom
codex/honor-prettierignore
Open

fix(prettier): honor .prettierignore during checks#2751
davehenton wants to merge 3 commits into
mainfrom
codex/honor-prettierignore

Conversation

@davehenton

Copy link
Copy Markdown
Member

Summary

  • run the Prettier plugin from the staged repo root so Prettier discovers .prettierignore correctly
  • include .gitignore in the plugin cache-affecting files to preserve Prettier's default ignore behavior
  • add a regression test covering an ignored file alongside a non-ignored unformatted file

Testing

  • cargo test -p qlty network_tests -- --ignored

Fixes #2499

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@qltysh

qltysh Bot commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Qlty


Coverage Impact - ubuntu-latest

⬆️ Merging this pull request will increase total coverage on main by 0.05%.

Modified Files with Diff Coverage (2)

RatingFile% DiffUncovered Line #s
Coverage rating: D Coverage rating: C
qlty-check/src/cache.rs100.0%
Coverage rating: A Coverage rating: A
qlty-check/src/executor/invocation_script.rs99.3%149
Total99.3%
🤖 Increase coverage with AI coding...
In the `codex/honor-prettierignore` branch, add test coverage for this new code:

- `qlty-check/src/executor/invocation_script.rs` -- Line 149

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@qltysh

qltysh Bot commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Qlty


Coverage Impact - macos-15

⬆️ Merging this pull request will increase total coverage on main by 0.05%.

Modified Files with Diff Coverage (2)

RatingFile% DiffUncovered Line #s
Coverage rating: D Coverage rating: C
qlty-check/src/cache.rs100.0%
Coverage rating: A Coverage rating: A
qlty-check/src/executor/invocation_script.rs99.3%149
Total99.3%
🤖 Increase coverage with AI coding...
In the `codex/honor-prettierignore` branch, add test coverage for this new code:

- `qlty-check/src/executor/invocation_script.rs` -- Line 149

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@davehenton
davehenton requested a review from marschattha April 14, 2026 19:55
Comment thread qlty-plugins/plugins/linters/prettier/plugin.toml Outdated
@isikyus

isikyus commented Jun 24, 2026

Copy link
Copy Markdown

This is affecting my current project — is there anything I could do to help get it merged?

For now, my workaround is to run prettier on the excluded lockfiles explicitly (pnpm ones, in my case). I'm hoping this will make the warning go away until I next update them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Prettier plugin does not honor .prettierignore

3 participants