Skip to content

Optimize schedule event search query - #4780

Merged
patrick91 merged 12 commits into
codex/remove-search-event-type-patchfrom
codex/optimize-search-events-for-schedule
Aug 15, 2026
Merged

patrick91 merged 12 commits into
codex/remove-search-event-type-patchfrom
codex/optimize-search-events-for-schedule

Conversation

@patrick91

@patrick91 patrick91 commented Aug 14, 2026

Copy link
Copy Markdown
Member

No description provided.

@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pycon Ready Ready Preview Aug 14, 2026 10:27pm

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.88%. Comparing base (9c5c035) to head (74a694d).

Additional details and impacted files
@@                           Coverage Diff                            @@
##           codex/remove-search-event-type-patch    #4780      +/-   ##
========================================================================
+ Coverage                                 92.85%   92.88%   +0.02%     
========================================================================
  Files                                       360      360              
  Lines                                     11161    11160       -1     
  Branches                                    893      891       -2     
========================================================================
+ Hits                                      10364    10366       +2     
+ Misses                                      675      674       -1     
+ Partials                                    122      120       -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@claude

claude Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Replaces the per-request _participants_data cache on GraphQL context with prefetching user.participants (via a new related_name="participants" on Participant.user) and filtering by conference in Python on each ScheduleItemUser/SubmissionSpeaker. Also restructures search_events_for_schedule to defer the union resolution into a results field so strawberry_django's optimize() can apply hints per-model.

No issues found.

Note for reviewers: the old context-level cache was actually a latent multi-tenant bug — a single GraphQL request touching two conferences (e.g. two aliased searchEventsForSchedule calls) would reuse participant data cached from the first conference for the second. This PR fixes that, and the new test_frontend_search_events_query_keeps_participants_scoped_by_conference test specifically covers it.

@patrick91
patrick91 merged commit 8392483 into main Aug 15, 2026
9 checks passed
@patrick91
patrick91 deleted the codex/optimize-search-events-for-schedule branch August 15, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant