Fix subcommands accepting --version

[7576457]

What does this PR do?

• issue: pip wheel . --version doesn't exit #9456

This PR forbids using pip <command> --version, leaving the --version option only for pip. At the same time, if such command is still executed, an error will be raised: no such option: --version

Example:

[hehs@nixos:~/dev/pip]$ pip wheel . --version

Usage:   
  pip wheel [options] <requirement specifier> ...
  pip wheel [options] -r <requirements file> ...
  pip wheel [options] [-e] <vcs project url> ...
  pip wheel [options] [-e] <local project path> ...
  pip wheel [options] <archive url/path> ...

no such option: --version

PR Checklist:

• I agree to follow the PSF Code of Conduct.
• I have read and have followed the CONTRIBUTING.md file.
• I have added a news file fragment (or this PR does not need one).
• I have read and followed the AI_POLICY.md file, and if any AI tools were used, I have disclosed it below.

[7576457]

Do we need a test here?

[2ykwang]

the root cause seems to be that --version is defined in the shared options group

https://github.com/pypa/pip/blob/main/src/pip/_internal/cli/cmdoptions.py#L1355-L1385

[2ykwang]

even with this check, --version still shows up in the subcommand's --help.

[7576457]

yes, it stays in subcommands since --version lives in general_group. I already tried removing it from there for the subcommand, but that broke some tests. Maybe there are other options

[7576457]

done.
found a way to suppress the hint without removing it :)

[2ykwang]

One thing that feels a bit off to me.

current implementation adds special-case handling just for --version. If possible, wouldn't it be better to avoid this kind of special case?

--version is only meaningful on the top-level pip command. So rather than keeping it in general_group, defining and handling it only in the top-level parser seems like a more natural structure to me.

That way:

• --version no longer shows up in pip <subcommand> --help
• there's no need for separate special-case handling anymore
• and future changes related to --version can be handled consistently at the parser level.

[2ykwang]

I already tried removing it from there for the subcommand, but that broke some tests. Maybe there are other options

My guess is the broken tests came from removing version from general_group. pip --version itself could no longer be handled. Looking at the code where pip processes the top-level command might help.

[7576457]

One thing that feels a bit off to me.

current implementation adds special-case handling just for --version. If possible, wouldn't it be better to avoid this kind of special case?

--version is only meaningful on the top-level pip command. So rather than keeping it in general_group, defining and handling it only in the top-level parser seems like a more natural structure to me.

That way:

* `--version` no longer shows up in `pip <subcommand> --help`

* there's no need for separate special-case handling anymore

* and future changes related to `--version` can be handled consistently at the parser level.

Damn, yeah, agreed. Much better this way.
Found how to do it. I ll remove it from general_options and add it as an option for pip, instead

[7576457]

done

[2ykwang]

If possible, it would be nice to have a regression test for pip <subcommand> --version.
Other than that, this looks good to me!

[7576457]

If possible, it would be nice to have a regression test for pip <subcommand> --version. Other than that, this looks good to me!

done