Finalize support for --no-binary with -r pylock.toml - #14187
Open
sbidoul wants to merge 1 commit into
Open
Conversation
7 tasks
sbidoul
force-pushed
the
pylock-no-binary-sbi
branch
from
August 5, 2026 11:53
dd741ea to
6834c3d
Compare
sbidoul
force-pushed
the
pylock-no-binary-sbi
branch
from
August 5, 2026 12:08
6834c3d to
ba6a319
Compare
sbidoul
marked this pull request as ready for review
August 5, 2026 12:09
sbidoul
force-pushed
the
pylock-no-binary-sbi
branch
from
August 5, 2026 15:01
ba6a319 to
45bed1d
Compare
ichard26
reviewed
Aug 6, 2026
ichard26
left a comment
ichard26
left a comment
Member
There was a problem hiding this comment.
Test failures look real. It seems like you need to guard the FormatControl import by if TYPE_CHECKING since otherwise pip freeze and pip uninstall will import all of the index machinery unnecessarily.
sbidoul
force-pushed
the
pylock-no-binary-sbi
branch
from
August 6, 2026 06:16
45bed1d to
694d289
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
pylock.select()prefers wheels,--no-binarydid work only in some cases with-r pylock.toml.Waiting for pypa/packaging#1334 (packaging 26.3)