reject redirects to non-http(s) schemes in PipSession - #14171
Merged
Conversation
Member
|
Hi @Arawoof06, thanks for your contribution. |
Contributor
Author
|
Not intentional, just an oversight. Ticked it now, and updated the other PRs too. I use an LLM a little for research and sanity-checking, but the code is mine and I understand and stand behind it. Happy to walk through the redirect logic if you want to dig in. |
ichard26
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
pip mounts a
LocalFSAdapterforfile://URLs on the same session it uses for the index and for downloads, and requests follows a 3xxLocationinto any scheme the session has an adapter for. A remote server can therefore redirect a request to afile://URL and have pip read a local path throughLocalFSAdapter.send(on Windows a UNC target reaches an SMB share).get_redirect_targetnow refuses a redirect whose scheme is nothttp/https; relative targets keep the current scheme and directfile://requests are unaffected.PR Checklist:
I use an LLM lightly for research and to sanity-check things, but the code here is mine and I understand and take full responsibility for it.