-
Notifications
You must be signed in to change notification settings - Fork 3.3k
perf: Use Rich Status for batched spinner rendering instead of per-line updates #14026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KRRT7
wants to merge
45
commits into
pypa:main
Choose a base branch
from
KRRT7:ui-refactor-perf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
e05770d
Consolidate spinner and progress bar functionality into ui.py
KRRT7 6f56529
Fix logging to detect TTY and control terminal rendering appropriately
KRRT7 1249581
Remove spinner parameter from call_subprocess
KRRT7 c8d2dee
Update imports and use status() context manager instead of open_spinner
KRRT7 3c456b0
Delete spinners.py and progress_bars.py, update tests for ui module
KRRT7 bd00385
cleanup these.
KRRT7 25c4bd4
Create ui-refactor-perf.feature.rst
KRRT7 57dd03a
Merge branch 'main' into ui-refactor-perf
KRRT7 6efe3be
remove interface and apply formatter
KRRT7 431a863
remove spinner
KRRT7 71967c0
Delete uv.lock
KRRT7 77daee1
update news file
KRRT7 6b764c4
update
KRRT7 ffbf339
Merge branch 'main' into ui-refactor-perf
KRRT7 88e9d31
Merge branch 'main' into ui-refactor-perf
KRRT7 bf8356b
Update ci.yml
KRRT7 60ddd38
Revert "Update ci.yml"
KRRT7 78b5f84
re-order imports
KRRT7 e3f6c83
Merge remote-tracking branch 'origin/main' into ui-refactor-perf
KRRT7 d9e363c
Resolve build_env merge conflict
KRRT7 d2438d1
Remove unused build_env import
KRRT7 6e06b55
Merge branch 'main' into ui-refactor-perf
KRRT7 9a92be4
Address UI spinner review feedback
KRRT7 602a0bb
Fix spinner console fallback
KRRT7 db56224
Merge branch 'main' into ui-refactor-perf
KRRT7 8a89dc5
Preserve legacy build status output
KRRT7 182a77d
Merge remote-tracking branch 'upstream/main' into pr/14026
KRRT7 08ffffa
Merge branch 'main' into ui-refactor-perf
KRRT7 0525ad7
Merge branch 'main' into ui-refactor-perf
KRRT7 e351a7b
Merge branch 'main' into ui-refactor-perf
KRRT7 c760425
Merge remote-tracking branch 'upstream/main' into pr-14026
KRRT7 e8c4ba2
Reduce spinner refactor to minimal API-preserving change
KRRT7 279f285
Merge branch 'main' into ui-refactor-perf
KRRT7 8df8f5d
Fix spinner test lint warning
KRRT7 54be458
bench: add ASV spinner benchmark
KRRT7 1832cce
bench: fix spinner benchmark pre-commit issues
KRRT7 4113906
Update AUTHORS.txt
KRRT7 98f39cb
Bump for release
KRRT7 026c91d
Bump for development
KRRT7 25a1cd6
bench: include ASV files in sdist
KRRT7 b408372
revert accidental release prep changes
KRRT7 9d66178
Merge branch 'main' into ui-refactor-perf
KRRT7 fef8122
Preserve completed interactive spinner output
KRRT7 335c9de
Add PTY spinner comparison harness
KRRT7 95746cf
Limit Rich status to rich spinner path
KRRT7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Consolidate spinner and progress bar functionality into a unified ``ui`` module and switch to Rich's ``Status`` context manager for proper spinner rendering. This improves performance by eliminating per-line syscall overhead and enabling Rich's optimized terminal batching, while fixing issues with ANSI codes appearing in test output. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.