fix: validate include-group items as strings and accept Mapping items - #46
Merged
Merged
Conversation
The include-group value was not checked to be a str, so a non-str value raised a cryptic TypeError deep in name normalization; it now raises a clear ValueError. Also, include items were checked with isinstance(item, dict), rejecting other Mapping types such as MappingProxyType; the check now uses collections.abc.Mapping to match the type hints. Assisted-by: ClaudeCode:claude-fable-5
henryiii
commented
Aug 5, 2026
A wrong type is a TypeError, not a ValueError; the lint CLI catches both. Also add a changelog entry for both fixes. Assisted-by: ClaudeCode:claude-fable-5
henryiii
marked this pull request as ready for review
August 5, 2026 22:20
sirosen
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Two small validation fixes in
_parse_group:include-groupvalue (e.g.{"include-group": 5}) failed with a crypticTypeErrorinside name normalization. It now raises a clearTypeError: Invalid include-group value, must be a string: ..., which the lint CLI catches.isinstance(item, dict), which rejected otherMappingtypes such astypes.MappingProxyType, even though the type hints acceptMapping. The check now usescollections.abc.Mapping.Regression tests and a changelog entry added.