Respect configured NuGet package sources - #2966
Open
CAOShurong wants to merge 2 commits into
Open
Conversation
joerick
reviewed
Aug 12, 2026
joerick
left a comment
joerick
left a comment
Contributor
There was a problem hiding this comment.
CI is passing so I'm happy
| ("arch", "free_threaded", "package_name"), | ||
| [("AMD64", False, "python"), ("ARM64", True, "pythonarm64-freethreaded")], | ||
| ) | ||
| def test_nuget_args_use_configured_sources( |
Contributor
There was a problem hiding this comment.
Suggested change
| def test_nuget_args_use_configured_sources( | |
| def test_get_nuget_args( |
Author
There was a problem hiding this comment.
Applied in 51c5d3f; the focused Windows tests still pass. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2961.
Summary
-FallbackSourcefrom Windows CPython installs.Testing
pytest unit_test/get_platform_test.py(7 passed)PYTHONUTF8=1 nox -s tests -- unit_test(854 passed, 68 skipped, 3 xfailed)pre-commit run --files cibuildwheel/platforms/windows.py unit_test/get_platform_test.pypylint cibuildwheel/platforms/windows.pyinstall_cpythonwith an empty local-only NuGet source: it reported only that source and failed as expected.install_cpythonwith nuget.org explicitly configured: it installed CPython 3.14.1 successfully.