feat(distributions): support symbolic eta in LKJCholeskyCov logp - #8404
Open
sankhyanreyansh wants to merge 1 commit into
Open
feat(distributions): support symbolic eta in LKJCholeskyCov logp#8404sankhyanreyansh wants to merge 1 commit into
sankhyanreyansh wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8404 +/- ##
=======================================
Coverage 91.87% 91.88%
=======================================
Files 128 128
Lines 21256 21253 -3
=======================================
- Hits 19530 19529 -1
+ Misses 1726 1724 -2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows the
etaparameter inpm.LKJCholeskyCovto be a symbolic/dynamic PyTensor variable (e.g., placing a prior such aspm.HalfNormaloneta), bringing it to feature parity withLKJCorr.logp.try...except NotScalarConstantErrorrestriction onetain_LKJCholeksyCovRV_logp.n(since static matrix dimensioning is required by PyTensor shape indexing).pymc/distributions/multivariate.py.tests/distributions/test_multivariate.pyverifying finitelogpanddlogpevaluations with symboliceta, as well as validating that non-constantnstill raisesNotImplementedError.Related Issue
Checklist
Type of change