Implement icdf for Truncated distributions - #8371
Open
prisharai wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Registers _icdf for TruncatedRV so pm.icdf works with pm.Truncated whenever the base distribution has an icdf.
Follows the suggestions in #8354 (comment): uses _create_logcdf_exprs (which handles the -1 for discrete), rescales the quantile onto [cdf(lower), cdf(upper)] in logspace, and passes it to the base icdf. This is the same expression rv_op uses for inverse-CDF sampling. q = 1 maps exactly to cdf(upper) so roundoff can't push it past the boundary. Bases without an icdf still raise NotImplementedError.
Related Issue
Checklist
Type of change