feat: Add location and begin_time fields to SponsoredEventListSerializer and update tests - #1273
Merged
Merged
Conversation
…zer and update tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1273 +/- ##
==========================================
+ Coverage 74.60% 78.80% +4.19%
==========================================
Files 84 85 +1
Lines 3186 3250 +64
==========================================
+ Hits 2377 2561 +184
+ Misses 809 689 -120 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
I cannot reproduce but the changes look harmless. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Thanks for sending a pull request! Please fill in the following content to let us know better about this change.
Please put an
xin the box that appliesDescription
add missing response field in sponsor talks.
Steps to Test This Pull Request
Steps to reproduce the behavior:
request /events/speeches/?event_types=talk,sponsored
Expected behavior
talk and sponsor talk data struct same