Skip to content

feat: Add location and begin_time fields to SponsoredEventListSerializer and update tests - #1273

Merged
serkodev merged 1 commit into
masterfrom
feat/sponsored-talk-response
Aug 25, 2026
Merged

feat: Add location and begin_time fields to SponsoredEventListSerializer and update tests#1273
serkodev merged 1 commit into
masterfrom
feat/sponsored-talk-response

Conversation

@serkodev

Copy link
Copy Markdown
Member

Types of changes

Thanks for sending a pull request! Please fill in the following content to let us know better about this change.
Please put an x in the box that applies

  • Bugfix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other (please describe)

Description

add missing response field in sponsor talks.

Steps to Test This Pull Request

Steps to reproduce the behavior:
request /events/speeches/?event_types=talk,sponsored

Expected behavior

talk and sponsor talk data struct same

@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.80%. Comparing base (aed3685) to head (e5f24b5).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1273      +/-   ##
==========================================
+ Coverage   74.60%   78.80%   +4.19%     
==========================================
  Files          84       85       +1     
  Lines        3186     3250      +64     
==========================================
+ Hits         2377     2561     +184     
+ Misses        809      689     -120     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@serkodev
serkodev requested a review from limouren August 25, 2026 07:06
@limouren

Copy link
Copy Markdown
Contributor

I cannot reproduce but the changes look harmless. LGTM.

@limouren limouren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serkodev
serkodev merged commit f90e68e into master Aug 25, 2026
3 checks passed
@serkodev
serkodev deleted the feat/sponsored-talk-response branch August 25, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants