[Repo Assist] improve(gcm/ml): correct np.array → np.ndarray in method type annotations - #1745
Draft
github-actions[bot] wants to merge 1 commit into
Conversation
…ions np.array is a function, not a type. Using it in type annotations (: np.array) is incorrect and misleads type-checkers and IDEs. The correct annotation for NumPy arrays is np.ndarray. Affected signatures: - ClassificationModel.predict_probabilities (abstract base) - SklearnClassificationModel.predict_probabilities - SklearnClassificationModelWeighted.predict_probabilities - SklearnRegressionModel.predict No functional change — type annotations do not affect runtime behaviour. All existing tests pass unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
78 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR is created by Repo Assist, an automated AI assistant.
Problem
Four method signatures in the GCM ML layer use
np.arrayas a type annotation:np.arrayis a function, not a type. Using it as a type annotation (X: np.array) is technically incorrect — it tells type checkers and IDEs thatXshould be thearrayfunction itself, not a NumPy array. The correct annotation for NumPy arrays isnp.ndarray.Fix
Replace the four incorrect
np.arrayannotations withnp.ndarray:dowhy/gcm/ml/classification.pyClassificationModel.predict_probabilities(abstract)dowhy/gcm/ml/classification.pySklearnClassificationModel.predict_probabilitiesdowhy/gcm/ml/classification.pySklearnClassificationModelWeighted.predict_probabilitiesdowhy/gcm/ml/regression.pySklearnRegressionModel.predictNo functional change — type annotations are not enforced at runtime.
Test Status
✅ All 12 tests in
tests/gcm/test_fcms.pypass unchanged.✅
black --checkclean on both modified files.✅
isort --checkclean on both modified files.✅
flake8clean on both modified files (no new errors).