Repository navigation
fix(reviews): load large pull requests correctly - #1577
Open
ValdemarGr wants to merge 1 commit into
Open
ValdemarGr wants to merge 1 commit into
ValdemarGr wants to merge 1 commit into
Conversation
Avoid the unused eager full-diff request, which GitHub rejects for PRs with more than 300 files. Paginate file viewed states before constructing the review so files beyond the first 100 retain their actual state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid the eager request for file nodes on a PR, which GitHub rejects for PRs with more than 300 files. Paginate file viewed states before constructing the review so files beyond the first 100 retain their actual state.
Describe what this PR does / why we need it
Opening large pull requests does not work properly, loading the comments fails after a certain PR size (406). This fixes it by using paginated API request.
Does this pull request fix one issue?
No, no issue found on this.
Describe how you did it
Use the graphql api with paged = true.
Describe how to verify it
review a pr of over 100 files changed, the "viewed file" flag wont import properly in octo
Special notes for reviews
I did use AI to synthesize this patch.
Checklist