Skip to content

Omit Trusted for deb822 sources when allow_unsigned is false - #1330

Open
bwitt wants to merge 1 commit into
puppetlabs:mainfrom
bwitt:deb822-trusted-false
Open

bwitt wants to merge 1 commit into
puppetlabs:mainfrom
bwitt:deb822-trusted-false

Conversation

@bwitt

@bwitt bwitt commented Oct 22, 2026 •

Copy link
Copy Markdown

Summary

Omit Trusted in the source file for deb822 sources when allow_unsigned is false

Add a spec test to cover this.

Related Issues (if any)

Fixes #1329

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@jst-cyr

jst-cyr commented Oct 27, 2026

Copy link
Copy Markdown
Member

Hey @bwitt , looks good at first glance, I've rebased and will kick off the acceptance testing so we can get some platform feedback.

@jst-cyr

jst-cyr commented Oct 27, 2026

Copy link
Copy Markdown
Member

Running CI tests for this PR via #1335

@jst-cyr

jst-cyr commented Oct 28, 2026

Copy link
Copy Markdown
Member

✅ Acceptance Test Results: https://github.com/puppetlabs/puppetlabs-apt/actions/runs/40586353135?pr=1335

Green across the board! Good on testing, needs code review from engineering.

@Phil-Friderici

Copy link
Copy Markdown

I've added some minor updates to the documentation and a unit test against @bwitt's branch as PR bwitt#1

Hope you like and merge it ;)

@jst-cyr

jst-cyr commented Nov 17, 2026

Copy link
Copy Markdown
Member

Thanks for the update @Phil-Friderici . Note that this hasn't had engineering review and with the additional changes I'll need to make sure we get a fresh acceptance test result on this one. I'll kick that off now so we have an update on acceptance testing status.

Signed-off-by: Brian Witt <brianwitt@gmail.com>
@jst-cyr

jst-cyr commented Nov 17, 2026

Copy link
Copy Markdown
Member

Test PR created to run CI against this change: #1341

@jst-cyr

jst-cyr commented Nov 17, 2026

Copy link
Copy Markdown
Member

✅ Acceptance Test Results: https://github.com/puppetlabs/puppetlabs-apt/actions/runs/44008037751?pr=1341

All green, tests are good, engineering review still needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deb822 does the wrong thing for allow_unsigned => false

3 participants