Repository navigation
Conversation
92b9acd to
a7aaa4e
Compare
|
Hey @bwitt , looks good at first glance, I've rebased and will kick off the acceptance testing so we can get some platform feedback. |
|
Running CI tests for this PR via #1335 |
|
✅ Acceptance Test Results: https://github.com/puppetlabs/puppetlabs-apt/actions/runs/40586353135?pr=1335 Green across the board! Good on testing, needs code review from engineering. |
|
Thanks for the update @Phil-Friderici . Note that this hasn't had engineering review and with the additional changes I'll need to make sure we get a fresh acceptance test result on this one. I'll kick that off now so we have an update on acceptance testing status. |
Signed-off-by: Brian Witt <brianwitt@gmail.com>
a7aaa4e to
c5c1ac3
Compare
|
Test PR created to run CI against this change: #1341 |
|
✅ Acceptance Test Results: https://github.com/puppetlabs/puppetlabs-apt/actions/runs/44008037751?pr=1341 All green, tests are good, engineering review still needed. |
Summary
Omit
Trustedin thesourcefile for deb822 sources whenallow_unsignedis falseAdd a spec test to cover this.
Related Issues (if any)
Fixes #1329
Checklist
puppet apply)