Skip to content

Include apt in defines that use apt class variables - #1314

Open
bwitt wants to merge 1 commit into
puppetlabs:mainfrom
bwitt:include-apt
Open

bwitt wants to merge 1 commit into
puppetlabs:mainfrom
bwitt:include-apt

Conversation

@bwitt

@bwitt bwitt commented Oct 16, 2026

Copy link
Copy Markdown

Summary

Add include apt in apt::setting apt::auth apt::ppa which all use apt variables, so that compilation does not fail when apt is not included somewhere else or later.

Also change options and package_name defaults to undef and fall back to apt values in the code. Default behavior is unchanged.

Related Issues (if any)

Fixes #1269
Fixes #1194

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@bwitt
bwitt requested review from a team, bastelfreak and smortex as code owners October 16, 2026 05:47
Signed-off-by: Brian Witt <brianwitt@gmail.com>
@jst-cyr

jst-cyr commented Oct 19, 2026

Copy link
Copy Markdown
Member

Thank you for the PR @bwitt ! Like others, I've rebased and am kicking off the test suite.

@jst-cyr

jst-cyr commented Oct 19, 2026

Copy link
Copy Markdown
Member

Running CI for this PR here: #1325

@jst-cyr

jst-cyr commented Oct 19, 2026

Copy link
Copy Markdown
Member

Acceptance Test Results: https://github.com/puppetlabs/puppetlabs-apt/actions/runs/39324666449?pr=1325

Full green on tests, next step is engineering review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Operator '[]' is not applicable to an Undef Value", at setting.pp $_proxy has Undef Value

2 participants