Repository navigation
Conversation
smortex
approved these changes
Oct 12, 2026
Signed-off-by: Brian Witt <brianwitt@gmail.com>
jst-cyr
force-pushed
the
deb822-include-architecture
branch
from
October 16, 2026 02:40
ad6d2f2 to
b0596af
Compare
Member
|
Thank you for the PR @bwitt ! I've rebased to update with latest and will kick off the acceptance tests on this one so we can get some early feedback. |
Member
|
Running CI tests for this PR here: #1313 |
Member
|
Acceptance Test Results: https://github.com/puppetlabs/puppetlabs-apt/actions/runs/38841770683?pr=1313 Green across the board! Looks good to go for an engineering review when the team is available. |
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make these two
apt::sourceparams behave likelistfor deb822 sources:typesdefault toundefso when not set it can be derived fromincludemerged withapt::include_defaults. The defaults still result in['deb']so the effective default is the same.aarch64asarm64forarchitectureAdditional Context
includeand skipped theaarch64rewritelist'sinclude_defaultsmerge andaarch64regexRelated Issues (if any)
Fixes #1304
Checklist
puppet apply)