Skip to content

Use include and normalize architecture for deb822 - #1305

Open
bwitt wants to merge 1 commit into
puppetlabs:mainfrom
bwitt:deb822-include-architecture
Open

bwitt wants to merge 1 commit into
puppetlabs:mainfrom
bwitt:deb822-include-architecture

Conversation

@bwitt

@bwitt bwitt commented Oct 11, 2026

Copy link
Copy Markdown

Summary

Make these two apt::source params behave like list for deb822 sources:

  • Make types default to undef so when not set it can be derived from include merged with apt::include_defaults. The defaults still result in ['deb'] so the effective default is the same.
  • Rewrite aarch64 as arm64 for architecture

Additional Context

Related Issues (if any)

Fixes #1304

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@bwitt
bwitt requested review from a team, bastelfreak and smortex as code owners October 11, 2026 16:21
Signed-off-by: Brian Witt <brianwitt@gmail.com>
@jst-cyr
jst-cyr force-pushed the deb822-include-architecture branch from ad6d2f2 to b0596af Compare October 16, 2026 02:40
@jst-cyr

jst-cyr commented Oct 16, 2026

Copy link
Copy Markdown
Member

Thank you for the PR @bwitt ! I've rebased to update with latest and will kick off the acceptance tests on this one so we can get some early feedback.

@jst-cyr

jst-cyr commented Oct 16, 2026

Copy link
Copy Markdown
Member

Running CI tests for this PR here: #1313

@jst-cyr

jst-cyr commented Oct 16, 2026

Copy link
Copy Markdown
Member

Acceptance Test Results: https://github.com/puppetlabs/puppetlabs-apt/actions/runs/38841770683?pr=1313

Green across the board! Looks good to go for an engineering review when the team is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

apt::source with source_format => 'sources' handles include and architecture differently

3 participants