feat: upgrade pubky bindings to 0.10 - #27
Conversation
|
@SeverinAlexB @andrei-21 adding you as reviewers since you worked on grant auth |
0e661e8 to
81b0c39
Compare
|
I don't have time to review. Andrei didn't work on grant auth. Best would be @86667 or @MCarlomagno. Also, fyi: https://github.com/pubky/pubky-homeserver/releases/tag/v0.11.0 |
|
In that case please @86667 @MCarlomagno review if you can. Note that generated bindings have already been tested in pubky-ring via pubky/react-native-pubky#39 and pubky/pubky-ring#360. Changes just need a code review for correctness. |
MCarlomagno
left a comment
There was a problem hiding this comment.
@pwltr Overall LGTM, but AI found something funny
Grant auth URLs are rejected by the SDK’s own parser. start_grant_auth_flow emits
pubkyauth://signin_grant?..., but parse_pubky_auth_url only accepts signin and signup.
Which seems like a legit issue, can you check that?
|
Drafted for fixes, also noticed missing |
81b0c39 to
df6c279
Compare
|
@MCarlomagno The grant auth parser issue should be fixed now: I also added |
Summary
Verification
Note: I also ran the full cargo test locally. The parser/deeplink coverage passed, but the network-dependent tests cannot complete in this sandbox because DHT socket initialization fails with PermissionDenied and poisons shared state.