feat(ui): add onboarding tags of interest step (#2387) - #2394
Open
Orlandohub wants to merge 4 commits into
Open
Conversation
Insert a "Tags of interest" step after profile creation where users pick up to 5 ordered interest tags (21 popular hot-tag chips + free text) that seed the starter pack follow recommendations in #2388. Changes: - Add /onboarding/tags route, page, template, and organisms - Remap onboarding stepper to the 4-step design model - Persist interestTags and per-pubky experienceCompletedByPubky in the onboarding store; completion survives reset() so an account is never re-prompted after logout/re-login - Redirect profile create success to the tags step; enable safe Back by rendering the profile step in edit mode when a profile already exists - Widen PostTag props to ButtonHTMLAttributes so chips accept disabled Completion is written on Tags Continue as a TEMPORARY(#2388) placement; #2388 relocates it to the Follow screen's Finish action. Refs: #2387
Contributor
Greptile SummaryThe follow-up adds persisted interest-tag restoration, prevents profile revisits from submitting unloaded defaults, and supplies colocated tests for the new onboarding organisms.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| src/components/organisms/TagsOfInterestForm/TagsOfInterestForm.tsx | Restores ordered selections from hydrated persisted state and synchronizes subsequent changes before onboarding navigation. |
| src/components/organisms/CreateProfileForm/CreateProfileForm.tsx | Detects profile revisits, uses edit mode, and blocks submission until the existing profile is loaded. |
| src/hooks/useProfileForm/useProfileForm.tsx | Supports an onboarding-specific edit redirect while preserving create and settings-edit behavior. |
| src/core/stores/onboarding/onboarding.store.ts | Persists selected interests and per-account Experience completion state. |
| src/components/organisms/TagsOfInterestForm/TagsOfInterestForm.test.tsx | Adds colocated rendering, persistence, and navigation coverage for the form. |
| src/components/organisms/TagsOfInterestHeader/TagsOfInterestHeader.test.tsx | Adds colocated content and snapshot coverage for the header. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Tags["Tags of interest"] -->|"selection persisted"| Store["Onboarding store"]
Tags -->|"Back"| Profile["Profile revisit"]
Profile -->|"load existing details"| Edit["Edit mode"]
Edit -->|"Save or Back"| Tags
Tags -->|"Continue"| Home["Home"]
Reviews (2): Last reviewed commit: "fix(ui): persist interest selection acro..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
🚀 Preview DeploymentURL: https://pubky-app-pr-2394-fzxmjul7ya-oa.a.run.app
|
…submit Address PR review findings: - Seed useInterestTags from the persisted store selection (sanitized through the same canonical/validity/dedupe/cap invariants) and sync the store on every change, so Back, browser back, and guard redirects no longer discard the selected tags or their order - Disable the profile revisit submit while the current profile is still loading, preventing an empty edit form from overwriting the existing bio, links, and avatar when local data is absent and the fetch fails - Add colocated tests for TagsOfInterestForm and TagsOfInterestHeader per docs/component-testing.md Refs: #2387
Contributor
Author
|
@greptile-apps review |
- Hide the FAB on onboarding routes so it no longer overlaps Continue - Render a skeleton during profile revisit hydration instead of an interactive form (promotes the Settings skeleton to a shared ProfileFormSkeleton per the skeleton promotion rule) - Match Figma interest-section hierarchy: muted regular "(N selected)" counter and both helper subtitles - Restructure title JSX so the snapshot has no trailing whitespace
…boarding-tags-step
infin1t3
self-requested a review
August 24, 2026 06:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the onboarding "Tags of interest" step from #2387 (closes #2387). Stacked on #2391 (
feat/2386-starter-pack-stream-source) forSTARTER_PACK_MAX_TAGSvia GitHub stack #2395 — when #2391 merges, GitHub automatically re-targets this PR todevand cascades the rebase./onboarding/tagsroute after profile creation: 21 popular chips from hot tags (useHotTags, month timeframe) + free-textTagInput, capped at 5 ordered, canonical (trimmed/lowercase,isValidTagLabel) tags via the newuseInterestTagshook. Selection order is preserved — it becomes the starter pack stream ID order in [Feature]: Starter Packs — onboarding "Follow your best matches" step + Follow All & landing feed #2388.Headerlogic that keyed onstep === 5now keys on the profile/tags paths.interestTags(persisted, cleared byreset()to prevent cross-account leakage) andexperienceCompletedByPubky(persisted and preserved throughreset(), keyed per pubky) so a completed account is never re-prompted after logout/re-login, while a different account on the same browser still is.commitUpdate, redirect back to tags) when the user already has a profile, removing the double-commitCreatehazard.PostTagprops widened toButtonHTMLAttributesso chips acceptdisabled; at the 5-tag cap only unselected popular chips lock — selected chips stay removable.Temporary placement (synced to #2388)
markExperienceCompletedis written on Tags Continue (markedTEMPORARY(#2388)) because Tags is currently the last Experience screen. #2388 relocates the write to the Follow screen's Finish and retargets Continue — tracked as an explicit checklist item on #2388.Test plan
useInterestTags: order, cap, dedupe (case-insensitive), canonicalization, invalid labels, removal at capTagsOfInteresttemplate: chip rendering, "(N selected)" header, accessible pressed/disabled states, free-text→popular dedupe, Continue with 0 tags, ordered persistence + completion write, Back navigation, re-prompt guard (completed pubky redirects, other pubky still prompted, hydration gate)reset()preserves completion but clearsinterestTagsuseProfileForm: create-success →/onboarding/tags, edit default →/profile, editredirectTooverrideCreateProfileForm: revisit renders prefilled edit mode, Back enabled → tags, submit runscommitUpdate(nocommitCreate/bootstrap)npm run typecheck,npm run lint,npm run format:checkall greenVRT is out of scope per the issue (QA team handles it later).