Skip to content

fix (Bug): Unable to view all taggers of profile tag - #2350

Open
Abhishek7Tech wants to merge 9 commits into
pubky:devfrom
Abhishek7Tech:fix-view-all-taggers
Open

fix (Bug): Unable to view all taggers of profile tag#2350
Abhishek7Tech wants to merge 9 commits into
pubky:devfrom
Abhishek7Tech:fix-view-all-taggers

Conversation

@Abhishek7Tech

@Abhishek7Tech Abhishek7Tech commented Aug 14, 2026

Copy link
Copy Markdown

Closes #2344

When attempting to view list of all taggers of a profile post, the list is not scrollable as all the taggers profiles doesn't get fetched when user clicks the taggers list buttons.

Screenrecording

Screen.Recording.2026-08-14.181008.mp4

@greptile-apps

greptile-apps Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes profile-tag expansion so the complete set of taggers can be fetched and displayed, while preserving the existing post-taggers path.

  • Adds profile tagger retrieval and enrichment with avatar and display-name data.
  • Synchronizes TaggedList local state when its input tags change.
  • Restores explicit post identity and tag-kind handling for post taggers.
  • Corrects the user taggers controller return type to reflect the endpoint response variants.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains in the current implementation, and the previously reported issues are fixed or were established as invalid.

Important Files Changed

Filename Overview
src/components/molecules/TaggedList/TaggedList.tsx Coordinates the mutually exclusive profile and post tagger-fetch paths and keeps local tag state synchronized with incoming props.
src/hooks/usePostTaggers/usePostTaggers.ts Adds profile tagger fetching, deduplication, avatar enrichment, and locally cached user-name resolution.
src/core/controllers/user/user.ts Updates the declared taggers response type to match the application-layer response shapes.
src/components/molecules/TaggedItem/TaggedItem.utils.ts Adds conversion from tagger IDs to avatar-bearing display records.
src/hooks/usePostTaggers/usePostTaggers.types.ts Extends the hook contract with the profile tagger-fetch result type.

Reviews (2): Last reviewed commit: "push updates" | Re-trigger Greptile

Comment thread src/hooks/usePostTaggers/usePostTaggers.ts
Comment thread src/components/molecules/TaggedList/TaggedList.tsx
Comment thread src/components/molecules/TaggedList/TaggedList.tsx Outdated
@Abhishek7Tech

Copy link
Copy Markdown
Author

@greptileai review

@infin1t3

Copy link
Copy Markdown
Collaborator

Hey @Abhishek7Tech 👋

Thanks for the interest in Pubky, and for taking the time to open these PRs (the screen recordings are helpful). We appreciate people wanting to contribute.

A few notes so this can work well for everyone:

We’re a small team, and we review contributions against the existing architecture and conventions. One focused, well-understood change that matches how the codebase already works is much more useful than several PRs in parallel. Volume isn’t something we optimize for.

What helps a PR get a real review and a chance of merging:

  • Read AGENTS.md and docs/ first (especially architecture and component conventions). We don’t have a CONTRIBUTING.md yet; those files are the source of truth for now.
  • Work one issue at a time. Finish the review cycle on one PR before opening the next.
  • Please treat review comments as something to address (or explicitly disagree with) before adding more surface area.
  • AI tools are fine as an assistant. What we need from the author is ownership of the change: why this is the right place to fix it, that it follows existing patterns, and that it doesn’t introduce new edge cases.

If you’re up for it, pick the one PR you feel strongest about, make sure it follows the conventions above, and we’ll take a proper look. You’re welcome to close or pause the others in the meantime so we can give that one the attention it deserves.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to view all taggers of profile tag

2 participants