Skip to content

Task (U.I): Add check icons to side bar - #2346

Open
Abhishek7Tech wants to merge 2 commits into
pubky:devfrom
Abhishek7Tech:add-check-icons-to-side-bar
Open

Task (U.I): Add check icons to side bar#2346
Abhishek7Tech wants to merge 2 commits into
pubky:devfrom
Abhishek7Tech:add-check-icons-to-side-bar

Conversation

@Abhishek7Tech

@Abhishek7Tech Abhishek7Tech commented Aug 13, 2026

Copy link
Copy Markdown

Closes #2270

added check icons to side bar

Screen recording

Screen.Recording.2026-08-13.193437.mp4

@greptile-apps

greptile-apps Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds a responsive selected-state check icon to sidebar filter items.

  • Wraps each filter button in a flex container.
  • Displays a Lucide check icon for selected items below the large-screen breakpoint.

Confidence Score: 4/5

The filter interaction should be fixed before merging because tapping the newly visible check side of a selected row does not invoke its action.

The new wrapper separates part of the row's visible selection affordance from the button that owns the click handler, creating a dead tap target on mobile and tablet layouts.

Files Needing Attention: src/components/atoms/Filter/Filter.tsx

Important Files Changed

Filename Overview
src/components/atoms/Filter/Filter.tsx Adds mobile selected-state checks, but places the check outside the filter button's interactive area.

Reviews (1): Last reviewed commit: "disable checkbox for larger screen sizes" | Re-trigger Greptile

>
{children}
</Button>
{isSelected && <Check className="lg:hidden"></Check>}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Check sits outside click target

When a mobile or tablet user taps the visible check icon or the space beside it, the outer container receives the interaction while onClick remains attached only to the sibling button, causing that part of the selected filter row to do nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI]: Mobile: Add missing check icons to left sidebar

1 participant