Task (U.I): Add check icons to side bar - #2346
Open
Abhishek7Tech wants to merge 2 commits into
Open
Conversation
Contributor
Greptile SummaryThis PR adds a responsive selected-state check icon to sidebar filter items.
Confidence Score: 4/5The filter interaction should be fixed before merging because tapping the newly visible check side of a selected row does not invoke its action. The new wrapper separates part of the row's visible selection affordance from the button that owns the click handler, creating a dead tap target on mobile and tablet layouts. Files Needing Attention: src/components/atoms/Filter/Filter.tsx
|
| Filename | Overview |
|---|---|
| src/components/atoms/Filter/Filter.tsx | Adds mobile selected-state checks, but places the check outside the filter button's interactive area. |
Reviews (1): Last reviewed commit: "disable checkbox for larger screen sizes" | Re-trigger Greptile
| > | ||
| {children} | ||
| </Button> | ||
| {isSelected && <Check className="lg:hidden"></Check>} |
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2270
added check icons to side bar
Screen recording
Screen.Recording.2026-08-13.193437.mp4