Skip to content

feat (UI): Mobile: Remove titles on Hot page #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abhishek7Tech wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat (UI): Mobile: Remove titles on Hot page #2343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/organisms/HotActiveUsers/HotActiveUsers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export function HotActiveUsers({ limit = DEFAULT_USERS_LIMIT, className }: HotAc

return (
<Container overrideDefaults className={cn('flex w-full flex-col gap-2', className)} data-testid="hot-active-users">
<Heading level={5} size="lg" className="font-light text-muted-foreground">
<Heading level={5} size="lg" className="hidden font-light text-muted-foreground lg:block">

@greptile-apps greptile-apps Bot Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Standalone section loses its label

When a nonexistent profile is opened below the lg breakpoint, ProfileUserNotFoundDiscoveryView renders this reusable component without the Hot page's tab navigation, so hiding the heading leaves the active-users list unlabeled.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

{'Active users'}
</Heading>
{error ? (
Expand Down
6 changes: 3 additions & 3 deletions src/components/organisms/HotTagsCardsSection/HotTagsCardsSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export function HotTagsCardsSection({ className }: HotTagsCardsSectionProps) {
if (error) {
return (
<Container overrideDefaults className={cn('flex w-full flex-col gap-2', className)}>
<Heading level={5} size="lg" className="font-light text-muted-foreground">
<Heading level={5} size="lg" className="hidden font-light text-muted-foreground lg:block">
{'Hot tags'}
</Heading>
<Typography className="text-destructive">{'Failed to load tags'}</Typography>
Expand All @@ -93,7 +93,7 @@ export function HotTagsCardsSection({ className }: HotTagsCardsSectionProps) {
if (isEffectivelyLoading) {
return (
<Container overrideDefaults className={cn('flex w-full flex-col gap-2', className)}>
<Heading level={5} size="lg" className="font-light text-muted-foreground">
<Heading level={5} size="lg" className="hidden font-light text-muted-foreground lg:block">
{'Hot tags'}
</Heading>
<HotTagsCardsSectionSkeleton maxAvatars={maxAvatars} />
Expand All @@ -107,7 +107,7 @@ export function HotTagsCardsSection({ className }: HotTagsCardsSectionProps) {
className={cn('flex w-full flex-col gap-2', className)}
data-testid="hot-tags-cards-section"
>
<Heading level={5} size="lg" className="font-light text-muted-foreground">
<Heading level={5} size="lg" className="hidden font-light text-muted-foreground lg:block">
{'Hot tags'}
</Heading>
{featuredTags.length === 0 ? (
Expand Down
2 changes: 1 addition & 1 deletion src/components/templates/Feed/Hot/Hot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export function Hot() {

{/* Trending Posts - hidden via CSS when another tab is active on mobile */}
<Container overrideDefaults className={cn('flex flex-col gap-2', hidePosts && 'hidden')}>
<Heading level={5} size="lg" className="font-light text-muted-foreground">
<Heading level={5} size="lg" className="hidden font-light text-muted-foreground lg:block">
{'Trending posts'}
</Heading>
<TimelineFeed variant={TIMELINE_FEED_VARIANT.HOT} />
Expand Down