fix(examples): update js-sdk demo for @synonymdev/pubky 0.10 - #30
Merged
Merged
Conversation
The 0.10 bump (#13) renamed two APIs the demo still called, breaking the creator auth flow at its first step: - Pubky.startAuthFlow -> startCookieAuthFlow (same signature) - Signer.signinBlocking() now requires a clientId. Its no-arg equivalent is signinCookieBlocking(); the new signin/signinBlocking both panic ("unreachable") against the pinned pubky-core homeserver (75eb1324).
dzdidi
approved these changes
Aug 26, 2026
dzdidi
added a commit
that referenced
this pull request
Aug 26, 2026
* feat(js-sdk): expose authenticated session metadata * fix(auth): harden iframe callback delivery * feat(demo): add Paykit payment lock workflow * feat(compose): add isolated Paykit payment demo * docs: document Paykit payment demo workflow * fix: support Bitkit local wallet tests (#11) * fix: support Bitkit local wallet tests * fix: complete external wallet Paykit demo * chore: use fast Paykit handshake retries * fix: make local wallet E2E startup reliable * fix: hide recovery auth in external wallet mode * fix: use external creator profile for reader setup * examples: validate work locally Signed-off-by: dzdidi <dzdidi@users.noreply.github.com> * docs|examples: improve texts Signed-off-by: dzdidi <dzdidi@users.noreply.github.com> --------- Signed-off-by: dzdidi <dzdidi@users.noreply.github.com> Co-authored-by: dzdidi <dzdidi@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * match loopback localhost Signed-off-by: dzdidi <dzdidi@users.noreply.github.com> * allign docs, fix outputs Signed-off-by: dzdidi <dzdidi@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * feat(paykit): expose authenticated setup readiness (#28) Signed-off-by: dzdidi <dzdidi@users.noreply.github.com> * fix(examples): update js-sdk demo for @synonymdev/pubky 0.10 (#30) The 0.10 bump (#13) renamed two APIs the demo still called, breaking the creator auth flow at its first step: - Pubky.startAuthFlow -> startCookieAuthFlow (same signature) - Signer.signinBlocking() now requires a clientId. Its no-arg equivalent is signinCookieBlocking(); the new signin/signinBlocking both panic ("unreachable") against the pinned pubky-core homeserver (75eb1324). --------- Signed-off-by: dzdidi <dzdidi@users.noreply.github.com> Co-authored-by: benk10 <ben.kaufman10@gmail.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Taehwa Kim <hadeath03@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@synonymdev/pubky0.10 (#13) renamed two APIs the demo still called. Creator auth failed at step 1 (/api/demo-auth/start→ HTTP 500).start-demo-server.mjs:pubky.startAuthFlow→startCookieAuthFlow(same signature;startAuthFlowno longer exists)lib/pubky.mjs:signer.signinBlocking()→signinCookieBlocking()—signinBlockingnow requires aclientId, and bothsignin/signinBlockingpanic (unreachable) against the pinned pubky-core homeserver (75eb1324)Verified locally: creator → reader
paykit-paymentflow completes end to end.🤖 Generated with Claude Code