Skip to content

Disable Collection stub for newer doctrine/collections versions - #149

Open
Mika56 wants to merge 1 commit into
psalm:2.xfrom
Mika56:disable-collection-stubs
Open

Disable Collection stub for newer doctrine/collections versions#149
Mika56 wants to merge 1 commit into
psalm:2.xfrom
Mika56:disable-collection-stubs

Conversation

@Mika56

@Mika56 Mika56 commented Oct 24, 2023

Copy link
Copy Markdown

Refs #21 and #138

Rebased old commit on 2.x branch

This commit disables doctrine/collections stubs when the installed version of doctrine/collections is >=1.6.0, when they started adding their own, more correct, stubs

@orklah

orklah commented Oct 24, 2023

Copy link
Copy Markdown
Collaborator

Thanks! It does make a lot of tests fail though

@Mika56

Mika56 commented Jan 25, 2024

Copy link
Copy Markdown
Author

Can you restart the tests?

php low stable high
7.2
7.3
7.4
8.0

Seems to be broken on 7.2, 7.3, and low versions on 7.4 and 8.0. Probably something to do with the Doctrine version check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants