Skip to content

[BEHAVIOR] Add ability to choose between DATETIME and TIMESTAMP - #1978

Open
wollanup wants to merge 5 commits into
propelorm:masterfrom
wollanup:feat/timestampable-behavior
Open

wollanup wants to merge 5 commits into
propelorm:masterfrom
wollanup:feat/timestampable-behavior

Conversation

@wollanup

Copy link
Copy Markdown
Contributor

Closes #1971

@codecov-commenter

codecov-commenter commented Sep 18, 2023

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.27%. Comparing base (4f36eea) to head (85745f9).
⚠️ Report is 105 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1978   +/-   ##
=========================================
  Coverage     89.27%   89.27%           
- Complexity     8049     8052    +3     
=========================================
  Files           232      232           
  Lines         24519    24521    +2     
=========================================
+ Hits          21889    21891    +2     
  Misses         2630     2630           
Flag Coverage Δ
5-max 89.27% <100.00%> (+<0.01%) ⬆️
7.4 89.27% <100.00%> (+<0.01%) ⬆️
agnostic 67.47% <100.00%> (+<0.01%) ⬆️
mysql 69.84% <100.00%> (+0.03%) ⬆️
pgsql 69.87% <100.00%> (+0.03%) ⬆️
sqlite 67.81% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wollanup

wollanup commented Sep 18, 2023

Copy link
Copy Markdown
Contributor Author

Hi @michbeck and @dereuromark !
If you're interested by this PR, could you help me with the tests errors (8.2, pgsql) please ?
I'm not sure to find the cause easily. Maybe a problem saving a book [here] ?(

$this->createBook($author3, 1);
)

Thanks for any help !

@smhg

smhg commented Jul 6, 2025

Copy link
Copy Markdown
Contributor

@PhilinTv this can be closed too I think. You can already specify the type (see #1971).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FRW-2182 extend TimestampableBehavior with is_timestamp parameter to allow configuration of datetime type for created_at and updated_at

5 participants