-
Notifications
You must be signed in to change notification settings - Fork 309
Add p5.sound CDN link to download page #1560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
b5873b7
f965fd9
969391a
8855c21
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ import LinkButton from '../../../components/LinkButton/index.astro' | |
| import CodeContainerWithCopy from "../../../components/CodeContainer/CodeContainerWithCopy.astro"; | ||
| import { | ||
| cdnLibraryUrl, | ||
| cdnSoundUrl, | ||
| fullDownloadUrl, | ||
| libraryDownloadUrl, | ||
| minifiedLibraryDownloadUrl, | ||
|
|
@@ -21,7 +22,7 @@ This link redirects you to the p5.js Editor online so you can begin using p5.js | |
| <LinkButton variant='link' url={`https://editor.p5js.org?version=${p5Version}`}> p5.js Editor </LinkButton> | ||
|
|
||
| ### Download the Complete Library | ||
| This is a download containing the p5.js library file, the p5.sound addon, and an example project. It does not contain an editor. Visit [Get Started](/tutorials/get-started) to learn how to setup a p5.js project. | ||
| This is a download containing the p5.js library file and an example project. It does not contain an editor. Visit [Get Started](/tutorials/get-started) to learn how to setup a p5.js project. | ||
|
|
||
| <LinkButton variant='download' url={fullDownloadUrl}> Complete Library </LinkButton> | ||
|
|
||
|
|
@@ -33,6 +34,11 @@ These are downloads or links to the p5.js library file. No additional contents a | |
| <LinkButton variant='download' url={minifiedLibraryDownloadUrl}> p5.min.js </LinkButton> | ||
| </div> | ||
|
|
||
| ### Sound Support with p5.sound | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The jsdelivr package is "p5.sound" but the library and repo name is
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated, section is now titled "Sound Support with p5.sound.js" and the body text uses p5.sound.js consistently. Left the jsDelivr URL and link text pointing at the actual npm package name (p5.sound) since that's what jsDelivr calls it. |
||
| p5.sound is maintained as a separate library from p5.js. If your sketch needs sound, add p5.sound to your project **in addition to** p5.js using the CDN link below, or visit [p5.sound on jsDelivr](https://www.jsdelivr.com/package/npm/p5.sound) for other versions and download options. | ||
|
|
||
| <CodeContainerWithCopy>{cdnSoundUrl}</CodeContainerWithCopy> | ||
|
|
||
| ## Use p5.js from CDN | ||
|
|
||
| All versions of p5.js are hosted on a content delivery network (CDN), a geographically distributed group of servers. There are a couple different ways to access the JavaScript library from your code editor. | ||
|
|
@@ -51,4 +57,4 @@ Use the following URL if you'd like to ensure that you're always accessing the l | |
|
|
||
| ### Other Versions of p5.js | ||
|
|
||
| If you'd like to access an earlier version of p5.js, you can look up the corresponding URL on [p5.js' jsDelivr webpage](https://www.jsdelivr.com/package/npm/p5). | ||
| If you'd like to access an earlier version of p5.js, you can look up the corresponding URL on [p5.js' jsDelivr webpage](https://www.jsdelivr.com/package/npm/p5). | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about: "It does not contain an editor. It also does not contain p5.sound.js; please see below instructions for sound support."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, thanks! Now reads: "It does not contain an editor. It also does not contain p5.sound.js; please see below instructions for sound support."