feat: run dependency graphs - #75
Merged
Merged
Conversation
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Publishing a dependency closure requires running per-package preparation in dependency-first order: leaves pack first, each package receives its direct dependencies' results, and independent packages overlap. Without a shared runner, every orchestration layer would reimplement readiness tracking, result relay, and failure gating — and re-derive the same concurrency and error semantics slightly differently each time. For example, a naive sequential loop would turn the diamond case (core, two adapters, app) into four serialized steps, while an ad-hoc concurrent version risks running a dependent before its dependencies resolve or losing track of which result belongs to which package.
Changes
runDependencyGraph()takes generic nodes and a value-producing callback, validates duplicates, unknown keys, and cycles before invoking anything, then schedules leaves-first with independent nodes overlapping. Each callback receives only its direct dependencies' results, every node runs exactly once, and results return keyed by node. A callback failure rejects without invoking blocked dependents, while already-running independent work settles cleanly. The runner knows nothing about packages or Git — adaptingPublishGraphNodetargets into it is explicitly left for the manifest-rewriting stage.