fix: #19212 - Tab onKeyDown only stops propagation for handled keys - #19628
Open
luber wants to merge 2 commits into
Open
fix: #19212 - Tab onKeyDown only stops propagation for handled keys#19628luber wants to merge 2 commits into
luber wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19212
Problem
The Tab component's
onKeyDownhandler calledevent.stopPropagation()unconditionally for all keydown events, not just the keys it actually handles (Arrow keys, Home, End, PageUp/PageDown, Enter, Space).This prevented parent components from receiving keyboard events like
Escape, breaking common patterns such as closing a Dialog withEscapewhile a tab header is focused.Fix
Moved
event.stopPropagation()into each handledcaseblock. Unhandled keys (e.g.Escape) now fall through thedefaultcase and propagate to parent components as expected.