fix: #19590 - TreeSelect overlay position with virtual scroll - #19593
Open
macayu17 wants to merge 1 commit into
Open
fix: #19590 - TreeSelect overlay position with virtual scroll#19593macayu17 wants to merge 1 commit into
macayu17 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates TreeSelect to forward scrollHeight to the underlying tree only when virtual scrolling is enabled, and adds a regression test to verify the behavior.
Changes:
- Passes
scrollHeightinto the internal tree component conditionally whenvirtualScrollistrue. - Adds a unit test ensuring
scrollHeightis propagated when virtual scrolling is enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/primeng/src/treeselect/treeselect.ts | Conditionally binds scrollHeight to the underlying tree when virtual scroll is enabled. |
| packages/primeng/src/treeselect/treeselect.spec.ts | Adds a test validating scrollHeight propagation during virtual scrolling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1346
to
+1353
| const treeSelectInstance = testFixture.debugElement.query(By.directive(TreeSelect)).componentInstance; | ||
| const dropdown = testFixture.debugElement.query(By.css('.p-treeselect-dropdown')); | ||
| dropdown.nativeElement.dispatchEvent(new MouseEvent('mousedown', { bubbles: true })); | ||
| await testFixture.whenStable(); | ||
| testFixture.detectChanges(); | ||
| await new Promise((resolve) => setTimeout(resolve)); | ||
| await testFixture.whenStable(); | ||
| testFixture.detectChanges(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #19590
TreeSelect now passes its
scrollHeightto the innerp-treewhen virtual scrolling is enabled. Without that, the virtual scroller could miss the height used by the overlay wrapper and the panel could be positioned wrong when it opened above the input.Added a regression for the virtual scroll case.
Tested:
pnpm --filter primeng test:unit -- --include src/treeselect/treeselect.spec.tspnpm --filter primeng build